Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update lr_finder to check for attribute if not running fast_dev_run #5990

Merged
merged 7 commits into from
Feb 17, 2021
Merged

update lr_finder to check for attribute if not running fast_dev_run #5990

merged 7 commits into from
Feb 17, 2021

Conversation

rohitgr7
Copy link
Contributor

What does this PR do?

more info here: #5638 (comment)
In short lr_find should mimic the behavior of scale_batch_size when searching for lr_attribute.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 added feature Is an improvement or enhancement tuner labels Feb 15, 2021
@rohitgr7 rohitgr7 added this to the 1.2.x milestone Feb 15, 2021
@codecov
Copy link

codecov bot commented Feb 15, 2021 •
edited
Loading

Codecov Report

Merging #5990 (4015d4f) into master (141316f) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #5990   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         159     159           
  Lines       11192   11188    -4     
======================================
- Hits        10425   10392   -33     
- Misses        767     796   +29

carmocca
carmocca approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Nice job!

pytorch_lightning/tuner/lr_finder.py Outdated Show resolved Hide resolved
pytorch_lightning/tuner/lr_finder.py Outdated Show resolved Hide resolved
pytorch_lightning/tuner/lr_finder.py Outdated Show resolved Hide resolved
pytorch_lightning/tuner/lr_finder.py Show resolved Hide resolved
@Borda @carmocca
Apply suggestions from code review
1f293fa 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@rohitgr7 rohitgr7 enabled auto-merge (squash) February 16, 2021 18:08
@mergify mergify bot removed the has conflicts label Feb 16, 2021
@rohitgr7 rohitgr7 merged commit 99da0d9 into master Feb 17, 2021
@rohitgr7 rohitgr7 deleted the ref/tuner branch February 17, 2021 12:15
@Borda Borda modified the milestones: 1.2.x, 1.2 Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
feature Is an improvement or enhancement tuner
Projects
None yet
Milestone
pl:1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@rohitgr7 @Borda @carmocca @SkafteNicki